thgh / rollup-plugin-scss

Rollup and compile multiple .scss, .sass and .css imports
MIT License
135 stars 46 forks source link

Move node-sass to optionalDependencies #56

Closed weizhenye closed 4 years ago

weizhenye commented 4 years ago

node-sass requires download binary from Internet, which is usually not provided by proxy service like Artifactory, it needs extra works to make npm i work in enterprise intranet.

If node-sass is moved to optionalDependencies, it can be ignored by npm i --no-optional. And it should not affect normal npm i.

thgh commented 4 years ago

PR welcome! But it probably makes more sense for you to use https://classic.yarnpkg.com/en/docs/selective-version-resolutions/

nhoizey commented 4 years ago

This would also be useful if using Dart Sass (npm sass package), I guess.

thgh commented 4 years ago

Released in v2.6.1 🎉