Type of node-sass package

thgh / rollup-plugin-scss

Rollup and compile multiple .scss, .sass and .css imports

MIT License

135 stars 46 forks source link

Open the-homeless-god opened 3 years ago

the-homeless-god commented 3 years ago

Currently, node-sass has been marked as 'optional" dependency in package.json, but there are a few issues:

rollup-plugin-scss can't work without node-sass
project can't use installation like npm install --no-optional because rollup-plugin-scss will throws issues about missing of node-sass

Also some packages were deprecated

thgh commented 3 years ago

It can, using the sass package which does not require binaries
Woops, the readme should be updated to indicate that node-sass should be installed specifically.

sirikon commented 3 years ago

I would suggest to not include node-sass as an optional dependency and always require to specify the preferred sass package in package.json.

Currently want to use the plugin with sass (dart-sass) but node-sass gets installed anyway.

thgh commented 3 years ago

Let's do that for v3, PR welcome!

FlorianWendelborn commented 3 years ago

Thanks for fixing this. This simple change sped-up our install time in a medium-size monorepo by 70%: https://github.com/3YOURMIND/kotti/pull/403