thgh / vercel-sapper

Vercel builder for Sapper with SSR enabled
MIT License
191 stars 25 forks source link

Update README #28

Closed benmccann closed 4 years ago

benmccann commented 4 years ago

Replace Now with Vercel

Explain how to run the project - please check this part. I think that vercel both builds and deploys your projects, but am not sure. I don't use the platform at all. I'm just trying to make sure the docs are clear if we're sending people here from the official Sapper docs

thgh commented 4 years ago

Haha thanks, as a longtime user, one may forget step 4 😛 it's true: vercel builds and deploys your project and creates a unique url (for staging). vercel --prod does the same and assigns the production url.

I merged this in vercel branch and will rename master to now.

benmccann commented 4 years ago

It seems that Vercel is deploying two versions of most of their repos to npm. One with now in the name and one with vercel in the name. Probably for backwards compatibility and to provide a migration path.

But all their docs clearly call the command line tool vercel at this point, so I think that this PR would be a good one to merge into master or else users might be confused that these instructions don't match the instructions on the vercel site

thgh commented 4 years ago

Let's see => https://github.com/zeit/now/discussions/4468