search

thgh / vercel-sapper

Vercel builder for Sapper with SSR enabled
MIT License
191 stars 25 forks source link

Fix missing await in function `npmBuild` #41

Closed madacol closed 4 years ago

madacol commented 4 years ago

Function npmBuild was returning a Promise, so in the file index.js the variable prodDependencies when destructuring it acted as an empty object

Possibly solves #42

thgh commented 4 years ago

As far as I know, this code is equivalent so it will not change the behaviour of the builder.

madacol commented 4 years ago

Honestly I don't know, I should have made an issue instead of a PR.

What I noticed is that the variable prodDependencies is not providing any files to the to the createLambda function

thgh commented 4 years ago

prodDependencies only apply when this option is set: https://github.com/thgh/vercel-sapper#no-build-usage I think usually dependencies are managed automatically by Vercel.