search

thgreasi / ui-sortable-multiselection

Provide multiple element sorting in UI-Sortable
MIT License
30 stars 12 forks source link

Multiselection not working when disabling the debug info #17

Closed IvanKraljevic closed 8 years ago

IvanKraljevic commented 8 years ago

If you try to select multiple items when using $compileProvider.debugInfoEnabled(false) you'll get an error: TypeError: Cannot read property 'sortableMultiSelect' of undefined

This occurs because the directive tries to get the scope of the parent element. And because the debug info is disabled, the parent element's (or any other element's) scope is undefined.

Ui-sortable has the same problem in verisons prior to 0.13.3: https://github.com/angular-ui/ui-sortable/issues/291

thgreasi commented 8 years ago

Yes, that's true. As you saw, I fixed it on UI-Sortable but never upgraded the implementation of this directive. I will start working on it at some point.

thgreasi commented 8 years ago

@IvanKraljevic I just pushed the v0.4.x-dev branch that hopefully adds support for the case that debugInfo is disabled. Can you give it a try? If it works we can probably publish it during the weekend.

IvanKraljevic commented 8 years ago

Hi, I just tested it and everything is working as it should. Thanks for the quick response and fix. Cheers! :)

thgreasi commented 8 years ago

Great! I will schedule the release during the weekend!

Thodoris Greasidis Computer, Networking & Communications Engineer

thgreasi commented 8 years ago

Resolved with #18 and published as v0.4.0.