thgreasi / ui-sortable-multiselection

Provide multiple element sorting in UI-Sortable
MIT License
30 stars 12 forks source link

Add badge on drag #21

Closed vanatallin closed 8 years ago

vanatallin commented 8 years ago

Adding an option to display a badge with the number of dragged items if dragging multiple

thgreasi commented 8 years ago

That's great! I will try to find some time to merge this during the weekend. On the mean time let me share some of my thoughts:

Thodoris Greasidis Computer, Networking & Communications Engineer

vanatallin commented 8 years ago

Hi, thanks for your comments. I pushed some updates to the pull request. Let me know if you want me to change something else.

thgreasi commented 8 years ago

That's great & removes the need for an extra option! I will merge it today (I hope).

thgreasi commented 8 years ago

Great PR :+1: with just +-12 diff! The only thing that we can improve is the way that we retrieve the sortableOptions. Ideally this should be done in the helper callback, but we also have to find a way to make the implementation DebugInfo disabled compliant.