search

thgreasi / ui-sortable-multiselection

Provide multiple element sorting in UI-Sortable
MIT License
30 stars 12 forks source link

ui.item.sortable.cancel() not work #4

Closed Kisama closed 10 years ago

Kisama commented 10 years ago

When call ui.item.sortable.cancel() in update function, sortable item canceled but multi selected item is not canceled.

In my opinion, in update fucntion in extendOptions if(ui.item.sortable.received && !ui.item.sortable.isCanceled()){ ... } else { ui.item.siblings('.' + selectedItemClass).show(); // it is needed for fix this bug. }

thgreasi commented 10 years ago

Can you provide a fiddle/pen? I will give it a try tonight. Thanks!

thgreasi commented 10 years ago

Sorry it took me so long to put some effort to this. I was busy with mozilla/localForage. The rest of the week will be ui-sortable + ui-sortable-multiselection.

thgreasi commented 10 years ago

@Kisama Please take a look at PR #5, it should properly handle cancel() now. The examples are also updated to demonstrate the case. If you find it to work for you as well, then we can merge it to master as v0.1.1 or something.

Kisama commented 10 years ago

Thank you, It works good. and I found another bug, I create new issue about that

thgreasi commented 10 years ago

Just released v0.2.0. Thanks for your feedback!