Open Robsteranium opened 3 years ago
Sorry, I should've investigated a bit further before posting.
Updating the webpack dependency after generation solves the above problem, but yarn build
/yarn start
still fails with lots more errors. Most seem to be caused by changes to typescript syntax but several appear to be because the API of e.g. @thi.ng/atom
has changed (and we're pointing at "latest").
One advantage to a github-template would be that you could add a github workflow action to test the project, having it serve as an integration test of sorts.
Hi @Robsteranium - am so sorry, keep forgetting to update the readme for hdom and to deprecate this create-hdom-app
skeleton. I will make a note to do one more round updates to it (deps only), but generally, I'd consider the approach put forward by this template project as superseded by newer/better options/approaches. FWIW this skeleton generator is from an earlier era of umbrella (from before thi.ng/rstream & thi.ng/rdom became more usable) and I haven't had the bandwidth to keep this up-to-date and/or extract a common formula for how to use these newer packages. Thank you for the heads up and additional digging into this, though!
Ah thanks for the pointers - I'll take a look at those other packages!
After doing
yarn create hdom-app my-app
andyarn install
just now I'm seeing the same error that was reported in #3 and #5.It looks like this picks up version
0.4.3
ofcreate-hdom-app
from npm. Oddly that version doesn't appear to exist among the tags in this repo and appears to be higher than the version in thepackage.json
from the HEAD commit. Thegenerate.js
file included in the npm version includes"webpack": "^4.6.0"
which I gather is causing this problem.It looks like the code in HEAD has more up to date versions of this dependency. Perhaps a new version should be released to npm?
Alternatively, as suggested here, perhaps a github-template might be simpler.