search

thi-ng / umbrella

⛱ Broadly scoped ecosystem & mono-repository of 199 TypeScript projects (and ~180 examples) for general purpose, functional, data driven development
https://thi.ng
Apache License 2.0
3.41k stars 151 forks source link

fix: add @thi.ng/date dependency to axidraw #376

Closed aurelienbottazini closed 1 year ago

aurelienbottazini commented 1 year ago

I tried running the example for @thi.ng/axidraw.

It errored because of a missing dependency @th.ing/date That dependency is used on that line: https://github.com/thi-ng/umbrella/blob/develop/packages/axidraw/src/axidraw.ts#L4

This PR is just to add that missing dependency to @thi.ng/axidraw

postspectacular commented 1 year ago

Thank you @aurelienbottazini - there's actually a tool in the repo for checking all packages for these problems, but so far I'd always just run it manually & quite obviously forgot to run it recently... So I just also added it as task to the CI action. Btw. there also was another package dep missing (transducers), though this one was indirectly referred by other deps & included already...

aurelienbottazini commented 1 year ago

thanks a lot for the explanation on the tool to check that automatically. That's super interesting