search

thi-ng / umbrella

⛱ Broadly scoped ecosystem & mono-repository of 198 TypeScript projects (and ~175 examples) for general purpose, functional, data driven development
https://thi.ng
Apache License 2.0
3.31k stars 144 forks source link

Use hash from global $fx object #426

Closed jffaust closed 8 months ago

jffaust commented 8 months ago

The latest version of the fxhash snippet (now called project SDK) no longer exposes a global fxhash variable. Instead, we should use $fx.hash (See Usage section in documentation).

I added a check to support the new recommended method and kept the old one for backward compatibility.

Once this is merged, I'd be happy to send a PR to update the tpl-umbrella-fxhash project to use the new SDK (looks to be quite outdated, as the snippet in the index.html does not support fxparams).

jffaust commented 8 months ago

@postspectacular can you take a look at my PR? I'd love to be able to quickly fix this 😄

postspectacular commented 8 months ago

thanks @jffaust - I wasn't aware they've changed it meanwhile (even though I was aware of the new $fx object and submitted a PR to their repo myself months ago...). Will release asap (tomorrow AM, late here...)

postspectacular commented 8 months ago

@jffaust You're lucky - already releasing right now, but it will take ~10 mins until all done... let me know how it goes, please...

Ps. No biggie, but also still had to add the TS ambient declaration for the new $fx object: 171b717d8