search

thiago-glissoi / FFF-Line-Segmentation

The fff_segmenter algorithm is used to segment an acoustic signal obtained from a first layer 3D print into multiple acoustic blocks related to specific geometrical elements of the printed part, such as contour lines, raster lines, and transition between raster lines.
MIT License
0 stars 0 forks source link

Data structure for example usage #4

Closed olivecha closed 3 months ago

olivecha commented 3 months ago

The example usage does not provide sufficient information for eventual users to use this code with their data. Please explain in more detail how Data/Test... were obtained and how could eventual users obtain similar data structures from their printing data.

thiago-glissoi commented 3 months ago

Hey @olivecha,

Thanks for contributing with this issue!

We've updated the Documentation to address your feedback.

Specifically, we created a section called Acquirement of the Necessary Signals where the required information is now available.

If you need more details or have any other suggestions, feel free to let us know.

Best,

Thiago

olivecha commented 3 months ago

Thanks for the clarification. Maybe there is still a little gap on how the raw data was processed into Matlab files or perhaps this is handled by your signal acquisition tools? Lets say I have a CSV with columns "time", "DirX on/off", "DirY on/off" and a WAV file with a sample rate of 32 kHz how could I input that into your tool ? Also mention that the DirX/Y data is in every Test.mat file that was not clear in the documentation.

thiago-glissoi commented 3 months ago

Thanks for the clarification. Maybe there is still a little gap on how the raw data was processed into Matlab files or perhaps this is handled by your signal acquisition tools? Lets say I have a CSV with columns "time", "DirX on/off", "DirY on/off" and a WAV file with a sample rate of 32 kHz how could I input that into your tool ? Also mention that the DirX/Y data is in every Test.mat file that was not clear in the documentation.

To directly answer your question, the raw data 'processing' into Matlab files was conducted in the example datasets by the Data Acquisition Device (DAQ). As mentioned in the updated documentation, for all three of the example datasets, the DAQ used was the DL 850 oscilloscope from Yokogawa®, Tokyo, Japan. This DAQ present the option to save the waveform data directly in MATLAB format ( for reference, view page 16-10 of the DL850 user manual ).

The fff_segmenter script requires that you possess a single .mat file that holds:

  1. The sensor signal that will be segmented;
  2. The X axis direction signal;
  3. The Y-axis direction signal.

These signals, when the .mat is loaded to the MATLAB/Octave workspace, needs to be in double type one line multiple columns values. Also, the three signals need to be obtained synchronously (that is, at the start and end of the printing process), and at the same Sampling Frequency (Fs). This will guarantee that the three signals possess the same column numbers.

In the hypothetical situation you mentioned, an approach you could try is to use MATLAB/Octave input options to convert upon insertion to the workspace the original data structure in order to obtain three separate double type one line multiple columns variables.

I have updated the documentation to insert the information about the example dataset DAQ output, alongside the information that the DIRX/Y data is in every Test.mat file.

olivecha commented 3 months ago

That is more clear. It does make sense that a Matlab script takes Matlab files as an input.