search

thiagobustamante / typescript-ioc

A Lightweight annotation-based dependency injection container for typescript.
MIT License
526 stars 64 forks source link

Fix problems with IE when getting orignal constructor for injecting properties #24

Closed cfmano closed 6 years ago

cfmano commented 6 years ago

Fixes issue #12. However, there is problem with tests coverige, as long as these changes are done in non-exported class, so I'm not able to run separate tests outside of the module.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-2.6%) to 91.6% when pulling 6a93e2feee573495fdb1c383f87e6a898bfd33b9 on cfmano:master into 8778721092ee7428e72e269175d174a90250bae3 on thiagobustamante:master.

thiagobustamante commented 6 years ago

Hi @cfmano ,

Thanks for you PR. I did not test your code, but I think that your new function hasNamedConstructor should be called by getConstructorFromType.

cfmano commented 6 years ago

@thiagobustamante yes you are right. I forgot to push one commit. Now it should be OK.