search

thiagobustamante / typescript-ioc

A Lightweight annotation-based dependency injection container for typescript.
MIT License
526 stars 64 forks source link

Changing the type getType is returning #29

Closed nolazybits closed 6 years ago

nolazybits commented 6 years ago

getType() returns FunctionConstructor instead of Function now, as this will always be a "constructible" class that will be returned.

nolazybits commented 6 years ago

This is related to the first PR https://github.com/thiagobustamante/typescript-ioc/pull/26 and issue https://github.com/thiagobustamante/typescript-ioc/issues/25

type returned by getType should have been FunctionConstructor not Function

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.048% when pulling cb15038724b5c6cd617ab744d57bd647d1697305 on nolazybits:master into acbfe747b292ca5aab968814519309438b3428ad on thiagobustamante:master.

nolazybits commented 6 years ago

I've been tossing thie PR (as you can see :) ) and it seems it adds more problem to what it solves. So closing. Cheers