thiagocordeiro / laravel-translator

Search translation keys and insert into json to be translated
MIT License
84 stars 22 forks source link

Add option to use default language keys as value #50

Closed mbardelmeijer closed 2 years ago

mbardelmeijer commented 2 years ago

This PR adds the option to define the option use_keys_as_default_value. This will set the key to the value for the default_language set (by default, en).

Discussed in #34

Closes #34

thiagocordeiro commented 2 years ago

@mbardelmeijer thanks for the contribution, tests failed and you can have a look at the report.

As soon as it passes I'll create a new version for the changes.

Cheers,

mbardelmeijer commented 2 years ago

@thiagocordeiro have pushed the necessary code style changes. Tests are green locally, so perhaps with these code style changes, the workflow continues?

thiagocordeiro commented 2 years ago

@mbardelmeijer I've changed actions config to run the workflow automatically, however you can run all tests with composer tests script

mbardelmeijer commented 2 years ago

@thiagocordeiro thanks! Yeah, I'm running it locally but passes fully there, so it's a bit weird why it does return errors in the CI. Will look into it.

mbardelmeijer commented 2 years ago

@thiagocordeiro should be good now!

thiagocordeiro commented 2 years ago

@mbardelmeijer that's weird. Maybe you have composer dependencies outdated, anyway, since it is green now I've merged already, thanks a lot for contributing 😃