Scripts' codes | observations

[Ricky-Tigg]

Hello. You may prefer to make scripts' codes compact.

uninstall.sh

if [ -e /opt/pt ]; then
 (...)
 sudo rm -rf /opt/pt /usr/share/applications/cisco*-pt*.desktop
 sudo xdg-desktop-menu uninstall /usr/share/applications/cisco-pt*.desktop
 (...)
fi

install.sh

• Mention "www.netacad.com/portal/node/488" appears to be invalid; produced | "_Access Denied | You don't have permission to access "http://id.cisco.com/app/ciscoid_netacadhttpcanvasauthnetacadcom_1/exkl91gjeATNZmgN95d6/sso/saml?" on this server. (...)_"
• The uninstallation code could refer to uninstall.sh thus avoiding that code:

  if [ -e /opt/pt ]; then
  (...) 
  fi

• In respect to Packet Tracer, since the AMD64 architecture is the only one supported for Linux, Fedora user accordingly chooses the appropriate available Fedora release which is _x8664 in order to be able to run that product. RPM package managers, which arerpm and dnf, automatically select the appropriate architecture IDs for package to be installed via those managers, for instance noarch and _x8664. Then those IDs can be omitted in code. Also some expressions can be grouped.

  echo "Installing dependencies"
  sudo dnf -y install qt5-qt{multimedia,webengine,networkauth,websockets,webchannel,script,location,svg,speech}
  (...)

[thiagojolv]

Hi, Ricky! First, thank you so much for your contributions.

uninstall.sh

if [ -e /opt/pt ]; then
 (...)
 sudo rm -rf /opt/pt /usr/share/applications/cisco*-pt*.desktop
 sudo xdg-desktop-menu uninstall /usr/share/applications/cisco-pt*.desktop
 (...)
fi

This block is from official Cisco's script, but you are right, compact is better.

• Mention "www.netacad.com/portal/node/488" appears to be invalid; produced | "_Access Denied | You don't have permission to access "http://id.cisco.com/app/ciscoid_netacadhttpcanvasauthnetacadcom_1/exkl91gjeATNZmgN95d6/sso/saml?" on this server. (...)_"

I will replace for https://www.netacad.com/portal/resources/packet-tracer.