search

thiagomaf / CSCpromoters

The goal of CSCpromoters is to extract, export and plot sequences of promoter regions from the genome fasta files.
MIT License
3 stars 1 forks source link

Change `trim_distances()` name to `set_promoter_sizes()` #14

Closed thiagomaf closed 1 year ago

thiagomaf commented 1 year ago

For consistency. Vide below current names:

my_promoters2 <- annotations %>%
  filter_locus(.keep = c("chr1Hg0000021", "chr1Hg0000031", "chr1Hg0000041")) %>%
  get_promoter_distances() %>% 
  trim_distances(.min_size = 100, .max_size = 2000) %>% 
  get_promoter_sequences(.txdb = txdb)

Would become:

my_promoters2 <- annotations %>%
  filter_locus(.keep = c("chr1Hg0000021", "chr1Hg0000031", "chr1Hg0000041")) %>%
  get_promoter_distances() %>% 
  trim_promoter_distances(.min_size = 100, .max_size = 2000) %>% 
  get_promoter_sequences(.txdb = txdb)
thiagomaf commented 1 year ago

@MinYaoJhu - Should we?

thiagomaf commented 1 year ago

Even better, trim_distances() name to set_promoter_sizes()

MinYaoJhu commented 1 year ago

set_promoter_sizes() sounds good!