search

thiagoperes / IDMPhotoBrowser

Photo Browser / Viewer inspired by Facebook's and Tweetbot's with ARC support, swipe-to-dismiss, image progress and more
MIT License
2.71k stars 642 forks source link

Broken pod dependencies after 1.10.2 update #234

Open kjen93 opened 7 years ago

kjen93 commented 7 years ago

After updating pod to 1.10.2 i get the following error when building my project:

/Pods/IDMPhotoBrowser/Classes/IDMPhoto.m:140:22: No visible @interface for 'SDWebImageManager' declares the selector 'loadImageWithURL:options:progress:completed:'

I use SDWebImage 3.7.6. Please, specify correct SDWebImage dependency in podspec

eduardocallado commented 7 years ago

The latest version of IDMPhotoBrowser (1.10.2) is compatible with the latest version of SDWebImage (4.0).

If you need to use a previous version of SDWebImage, you can specify IDMPhotoBrowser to 1.10.1 on your Podfile, since that was the only change for this version.

Otherwise, update both pods, running 'pod update'.

kjen93 commented 7 years ago

There is another change in this version and I need it: https://github.com/thiagoperes/IDMPhotoBrowser/commit/08fbdc70bd8f9a3088527cbb34f9743cafbac1a4 This change https://github.com/thiagoperes/IDMPhotoBrowser/commit/68615687d6f40f50fecfb070abd2d0c759e9025f actually raises minimum requirement for SDWebImage to 4.0, but you didn't change minor version of the pod to indicate broken backwards compatibility.

Also you should specify minimum required version of SDWebImage in podspec, so Cocoapods can resolve dependencies correctly. At this moment your podspec indicates any SDWebImage version as the requirement, but this is no longer true.

eduardocallado commented 7 years ago

You're right, your pull request was also merged into 1.10.2. I will push a new 1.11 version to fix this dependency.