thiagoperes / IDMPhotoBrowser

Photo Browser / Viewer inspired by Facebook's and Tweetbot's with ARC support, swipe-to-dismiss, image progress and more
MIT License
2.71k stars 641 forks source link

s.dependency 'SDWebImage', '4.0.0' #289

Open jokerping opened 6 years ago

jokerping commented 6 years ago

When I used CocoaPod, my SDWebImage was downgraded,because you specified the version

fl0ge commented 6 years ago

I think pull request #267 solved that problem. This PR was merged into master on Mar 5 but no new version was released since that merge. You can either wait for the next release or use master branch in Podfile (using pod 'IDMPhotoBrowser', :git => 'https://github.com/thiagoperes/IDMPhotoBrowser.git', :branch => 'master').

jonathanfoster commented 5 years ago

@Matsepura fixed this issue back in November of 2017, https://github.com/thiagoperes/IDMPhotoBrowser/commit/265bb65bb7a3c64d3a95ce99f80db639b608ee51.

There have been a ton of improvements in SDWebImage since 4.0 so I consider this a critical release. On 4.0, my app was using 150-200 MB of memory. After updating to SDWebImage 4.4.6, memory dropped to 75 MB.

Who has permissions to tag a new release?

jonathanfoster commented 5 years ago

@thiagoperes, can you tag a new release that includes this fix?