search

thiagoralves / OpenPLC_Editor

OpenPLC Editor - IDE capable of creating programs for the OpenPLC Runtime
GNU General Public License v2.0
385 stars 191 forks source link

Mandatory references to original projects. #105

Closed etisserant closed 4 months ago

etisserant commented 4 months ago

This change is clearly stating origins of most of the source code in this repository, so that developers know where to find file history and know where to send pull requests.

Also, Beremiz is GPLv2. How can you re-license it as GPLv3 ?

thiagoralves commented 4 months ago

Changed license to GPLv2

etisserant commented 4 months ago

Regarding license change, GPLv2 makes a problem because of MatIEC is GPLv3. I think the problem is about bundling those two projects together. You should instead maintain a branch of both original projects, with your changes applied as individual commits. It would have the additional benefit for you to simplify applying changes from upstream.

thiagoralves commented 4 months ago

When I changed the license to GPLv2, I added a specific license file on MatIEC folder specifying that the subproject is GPLv3. Bundling both projects together makes it easier for users that just want to benefit from a complete solution.

thiagoralves commented 4 months ago

Also, what you said about keeping the original branch, that's something I might do in the future. I just need to dedicate some time to organize this better.