thiagoralves / OpenPLC_Editor

OpenPLC Editor - IDE capable of creating programs for the OpenPLC Runtime
GNU General Public License v2.0
429 stars 207 forks source link

Added editor and matiec as submodules #127

Closed thiagoralves closed 3 months ago

joluxer commented 3 months ago

Hi Thiago,

for now it is too late and I don't have the intention to change the project layout you chose. We will work for now using git-submodules. But I made the experience, that setting up a subrepo is a lot less hassle for the plain users of a project than a submodule. Subrepos appear to a plain cloning user like a monorepo and only contributors to the subrepo stuff need to take a different workflow.

Unfortunately, the update.cmd script for Windows is affected...

So for now I would take the job for improving the update scripts to work with those submodules. Hopefully, the functional gap produced no hassle yet. Stay tuned for a PR, please.

Best regards,

J'Lo

joluxer commented 3 months ago

Perhaps we can arrange the update process so, that the update procedure comes with the git clone and is no longer fixed in the installed scripts.

By the way: in contrast to the Windows world is it allowed to delete an open file in the UN*X world. So updating a running instance should be much easier in Linux and MAC, than on Windows...

Regards, J'Lo

thiagoralves commented 3 months ago

Hey @joluxer! Yeah, sub modules are not handy indeed. If I knew about the subrepo before I would’ve used that instead. Anyway, it is done and I don’t think it is worth changing it now anymore. About the update scripts, I’ve updated the installers for Windows, macOS and Linux with new scripts. I forgot to update the scripts here on the repo as well, but they’re not used much as most of the users install from the installers available at the Autonomy website. I’ll take a look at that on Monday and will update the scripts here accordingly.