thiagoralves / OpenPLC_Editor

OpenPLC Editor - IDE capable of creating programs for the OpenPLC Runtime
GNU General Public License v2.0
385 stars 191 forks source link

Some improvements #82

Closed francesco-fioretti closed 11 months ago

francesco-fioretti commented 11 months ago

-now the software sets the language of arduino-cli, so that its outputs are understandable to the software. -reads the installed boards before opening the form editor/dialogs/ArduinoUploadDialog.py, this way you don't have false information in the drop-down menu in the form, it also speeds up the compilation and loading process inside the microprocessor -added two scripts ("pip-install.py") and ("install.py") that install the necessary to run the software under windows, provided we have python2.7 and wxPython3.0 installed, also included in the repository, first run "pip-install.py" and after "install.py" -added support for iruino, a board produced by us (VEA SRL) based on esp32 for any technical issue you can contact us by email at "vea@vea.it", reference Francesco Fioretti Thank you very much :)

thiagoralves commented 11 months ago

Thank you for the updates! I'm checking the commits and will merge as soon as I finish validating the changes.

One thing, your commit has some config files that are specific to you last build (I guess I need to set proper .gitignore for these files). It is better to have the repository with clear config files so that users don't get your setup (like WiFi password for example) when they install the software. I will clean that up after merging.

Also, your VEA installer seems redundant and too specific, as it only works on Windows. OpenPLC already provides installers for all 3 platforms on the OpenPLC website. If you have a need for a specific installer for your platform, that should reside in your fork of the editor only. Any particular reason why you cannot use the generic OpenPLC installer?

francesco-fioretti commented 11 months ago

Thank you very much for the config files, can you tell me their filename please? I made the installer in order to try these changes on some of our windows machines, so feel free to remove the installer files, in case, how do you make the installer? So if I have to make other changes I can not "dirty" the fork with a specific installer

Thanks very much for your reply!

thiagoralves commented 11 months ago

Hi Francesco,

Here are the files that should have been ignored:

editor/arduino/examples/Baremetal/defines.h editor/arduino/examples/Baremetal/settings.json editor/arduino/src/LOCATED_VARIABLES.h editor/arduino/src/POUS.c editor/arduino/src/POUS.h editor/arduino/src/Res0.c editor/arduino/src/VARIABLES.csv editor/arduino/src/arduino.cpp editor/arduino/src/glueVars.c editor/arduino/src/plc_prog.st editor/examples/Blink/plc.xml

Could you please make another PR without those files please? If you can set a .gitignore for them it would be even better, and would help the overall project PRs experience for everyone :)

To test your changes, you can simply replace the "editor" and "matiec/lib" folders from an installed OpenPLC Editor with your own version. Once the code is pushed to the main repository here, a simple file -> check for updates will bring your changes over to any OpenPLC Editor installation.