thiagoralves / OpenPLC_Editor

OpenPLC Editor - IDE capable of creating programs for the OpenPLC Runtime
GNU General Public License v2.0
385 stars 191 forks source link

Some improvements #83

Closed francesco-fioretti closed 11 months ago

francesco-fioretti commented 11 months ago

as agreed in the previous pull request, I deleted our installer files, put the configuration files in the .gitignore file To summarise:

If everything is OK please accept my changes, so that we can 'officially' program our hw :) Thanks very much for your support :)

One more thing, for another our project I would need to make an installer like the one you made for OPENPLC, could you give me some tips please? Thank you very much :)

thiagoralves commented 11 months ago

Thanks! For the installer, I used NSIS: https://nsis.sourceforge.io/Download

thiagoralves commented 11 months ago

Francesco, I merged the PR, but now when I'm testing it I noticed that your changes to the board management removed the ability to populate the [NOT INSTALLED] with the package version (ex: [1.8.6]) for boards that are already installed in the system. Could you please fix this?

thiagoralves commented 11 months ago

Also, your builder.readBoardsInstalled() call is taking a LOOOOONG time and has no practical effect. The upload dialog is taking a good 5 seconds to open after this change, and that's not good. Board versioning is kept in the hals.json file for every board. You don't need to call arduino-cli for every board to validate if the board is installed or not. I'm removing this call for the time being until that's fixed.