Tx pause

[eriklagerwall]

Hi. I added support for a Transmission pause for Modbus RTU slave devices. Some (most?) half duplex slave devices won't acknowledge a new message without a pause on the bus. I added a setting for this, I have tested on a Raspberry Pi.

[thiagoralves]

Thanks Erik! I checked your commits but they seem to be based from an earlier master code. It is removing some recent corrections, specifically "Improve input sanitation by escaping possible HTML characters" (https://github.com/thiagoralves/OpenPLC_v3/commit/f61bfa7d5ed201859d82b7e00c601922835ad554) and "Fix issue with multiple RTU connected to same port" (https://github.com/thiagoralves/OpenPLC_v3/commit/f662bf36cd0e0c04450e17f9549c8613ef438eb1). Could you please clone the most recent code from github and add your changes again?

[thiagoralves]

I just realized that you actually improved the "Fix issue with multiple RTU connected to same port" (https://github.com/thiagoralves/OpenPLC_v3/commit/f662bf36cd0e0c04450e17f9549c8613ef438eb1). However, the code from html escaping is still missing.

[eriklagerwall]

Sorry my mistake, I'm not really used to working with Git. Will make shore I have the most resent code

[thiagoralves]

I guess the easiest way would be to just literally add back the code from this commit "Improve input sanitation by escaping possible HTML characters" (https://github.com/thiagoralves/OpenPLC_v3/commit/f61bfa7d5ed201859d82b7e00c601922835ad554) back in your sources and commit again. Another thing I also saw is that the tabs in your code is inconsistent with the source code. Please convert it all to "4 spaces" instead of using tabs ("\t")

[eriklagerwall]

Now I've added my code to the the most recent version.

The changes to "Fix issue with multiple RTU connected to same port" are from https://github.com/thiagoralves/OpenPLC_v3/pull/156 but since they changes the same file this branch contains the same change

[thiagoralves]

Thanks. Everything is merged to the master branch now.

[eriklagerwall]

Thank you! This is really a nice projekt. Made it quite easy to bild a PLC for some home automation

[thiagoralves]

Erik, turns out your last commit broke slave devices support. Check this user’s report on the forum: https://openplc.discussion.community/post/unable-to-add-arduino-slave-11993164?trail=15#1

[eriklagerwall]

Hi. Looks like the database did not get merged. Think its because the pause column is missing.

Den lör 23 okt. 2021 13:53Thiago Alves @.***> skrev:

Erik, turns out your last commit broke slave devices support. Check this user’s report on the forum: https://openplc.discussion.community/post/unable-to-add-arduino-slave-11993164?trail=15#1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thiagoralves/OpenPLC_v3/pull/157#issuecomment-950141163, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMDEWWA2QDOWW44MNRRIMDUIKO2JANCNFSM5GFIDIBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[eriklagerwall]

Now I have been looking more and some of my changes to webserver.py is missing, a new pull request is coming soon

Den lör 23 okt. 2021 14:15Erik Lagerwall @.***> skrev:

Hi. Looks like the database did not get merged. Think its because the pause column is missing.

Den lör 23 okt. 2021 13:53Thiago Alves @.***> skrev:

Erik, turns out your last commit broke slave devices support. Check this user’s report on the forum: https://openplc.discussion.community/post/unable-to-add-arduino-slave-11993164?trail=15#1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thiagoralves/OpenPLC_v3/pull/157#issuecomment-950141163, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMDEWWA2QDOWW44MNRRIMDUIKO2JANCNFSM5GFIDIBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.