Open bepstein opened 7 years ago
Can you add support to add also_notify arrays to the options section? Here is a patch that I believe will work.
`diff --git a/manifests/server/conf.pp b/manifests/server/conf.pp index 14fcbc1..070c128 100644 --- a/manifests/server/conf.pp +++ b/manifests/server/conf.pp @@ -41,6 +41,8 @@
+# $also_notify: +# Array of IP addrs or ACLs to send notifies to. Default: empty
@@ -109,6 +111,7 @@ define bind::server::conf ( $recursion = 'yes', $allow_recursion = [], $allow_transfer = [],
also-notify { <%= @also_notify.join("; ") %>; }; +<% end -%> <% if !@check_names.empty? -%> <% @check_names.each do |line| -%> check-names <%= line %>; @@ -116,7 +119,7 @@ logging { <% if !@views.empty? -%>
<% @views.sort_by {|key,value| key}.each do |key,value| -%> -<% valid_keys = %w(allow-notify allow-query allow-recursion allow-transfer allow-update-forwarding forwarders match-clients match-destinations match-recursive-only) -%> +<% valid_keys = %w(allow-notify allow-query allow-recursion allow-transfer also-notify allow-update-forwarding forwarders match-clients match-destinations match-recursive-only) -%> view "<%= key %>" { <% valid_keys.sort.each do |valid_key| -%> <% if value[valid_key] and !value[valid_key].empty? -%> `
Thanks, ep
Perhaps an attachment would be better.
also-notify.patch.txt
Can you add support to add also_notify arrays to the options section? Here is a patch that I believe will work.
`diff --git a/manifests/server/conf.pp b/manifests/server/conf.pp index 14fcbc1..070c128 100644 --- a/manifests/server/conf.pp +++ b/manifests/server/conf.pp @@ -41,6 +41,8 @@
Array of IP addrs or ACLs to allow recursion from. Default: empty
$allow_transfer:
Array of IP addrs or ACLs to allow transfer to. Default: empty
+# $also_notify: +# Array of IP addrs or ACLs to send notifies to. Default: empty
$check_names:
Array of check-names strings. Example: [ 'master ignore' ]. Default: empty
$extra_options:
@@ -109,6 +111,7 @@ define bind::server::conf ( $recursion = 'yes', $allow_recursion = [], $allow_transfer = [],
also-notify { <%= @also_notify.join("; ") %>; }; +<% end -%> <% if !@check_names.empty? -%> <% @check_names.each do |line| -%> check-names <%= line %>; @@ -116,7 +119,7 @@ logging { <% if !@views.empty? -%>
<% @views.sort_by {|key,value| key}.each do |key,value| -%> -<% valid_keys = %w(allow-notify allow-query allow-recursion allow-transfer allow-update-forwarding forwarders match-clients match-destinations match-recursive-only) -%> +<% valid_keys = %w(allow-notify allow-query allow-recursion allow-transfer also-notify allow-update-forwarding forwarders match-clients match-destinations match-recursive-only) -%> view "<%= key %>" { <% valid_keys.sort.each do |valid_key| -%> <% if value[valid_key] and !value[valid_key].empty? -%> `
Thanks, ep