search

thias / puppet-fooacl

Puppet POSIX ACLs module
Other
9 stars 20 forks source link

Convert from Bash to PHP #1

Closed StL-Jim closed 10 years ago

StL-Jim commented 10 years ago

In conf.pp and init.pp /usr/local/sbin/fooacl is now /usr/local/sbin/fooacl.php (to reflect it's php code and not bash code).

The templates now generate PHP code instead of Bash. The PHP code sorts the array alphabetically so that sub-directory ACLs don't get overwritten by parent dirs.

thias commented 10 years ago

As we discussed in our emails, changing from Bash to PHP is a little too extreme :-)

Python would be acceptable if really needed, but I think I fixed the issue with a simple "sort" call. Could you please tell me if 7484a5bf5baf178c9d2a037e842b5bcace5360df works for you?

StL-Jim commented 10 years ago

Hello Mattias,

Heh, I just took a look at your change….. Seriously, it was that easy? Pipe the output through sort… Nice! Well no one ever accused me of being bright.

Anyway, I’ll be checking it out later today.

From: Matthias Saou [mailto:notifications@github.com] Sent: Thursday, January 30, 2014 7:06 AM To: thias/puppet-fooacl Cc: Jim Miller Subject: Re: [puppet-fooacl] Convert from Bash to PHP (#1)

As we discussed in our emails, changing from Bash to PHP is a little too extreme :-)

Python would be acceptable if really needed, but I think I fixed the issue with a simple "sort" call. Could you please tell me if 7484a5bhttps://github.com/thias/puppet-fooacl/commit/7484a5bf5baf178c9d2a037e842b5bcace5360df works for you?

— Reply to this email directly or view it on GitHubhttps://github.com/thias/puppet-fooacl/pull/1#issuecomment-33685769.

thias commented 10 years ago

Have you managed to test my change? Does it do what you expected? My own testing shows that it should, but I'd like your feedback before closing this issue and releasing 0.1.1 on the forge.

thias commented 10 years ago

It's been working fine for me, and I think it should do what was initially requested, so closing.