search

thias / puppet-php

Puppet module to manage PHP
Other
49 stars 67 forks source link

Pahoughton test #28

Open pahoughton opened 10 years ago

pahoughton commented 10 years ago

Minor fix in ini.pp and cli.pp. Changed so package is installed before ini. The package creates the ini files subdirectory on Debian.

Added travic-ci basic unit testing.

Thanks for providing this module!

thias commented 10 years ago

Hmm, some changes make sense, but others don't, such as changing all of the 'include' to 'class' when not passing parameters (I'm quite certain that this syntax makes it fail when then referencing the class to be included multiple times with certain versions of puppet), or having the build status of your branch displayed on mine...

Could you maybe break this PR into various, sequentially, starting with what you consider the most important?

pahoughton commented 10 years ago

Major rework pending, lets review the next commit and decide what we want (this weekend).

include vs class - agree this is a issue, looking for the best answer still.

Enjoy Today, TTFN, paul :+} Facebook LinkedIn

On May 12, 2014, at 05:09 , Matthias Saou notifications@github.com wrote:

Hmm, some changes make sense, but others don't, such as changing all of the 'include' to 'class' when not passing parameters (I'm quite certain that this syntax makes it fail when then referencing the class to be included multiple times with certain versions of puppet), or having the build status of your branch displayed on mine...

Could you maybe break this PR into various, sequentially, starting with what you consider the most important?

— Reply to this email directly or view it on GitHub.