thias / puppet-php

Puppet module to manage PHP
Other
49 stars 67 forks source link

Changed always_populate_raw_post_data to Off which is the default from p... #65

Closed bschonec closed 9 years ago

bschonec commented 9 years ago

The default value of 'always_populate_raw_post_data' is "0" (off) according to http://php.net/manual/en/ini.list.php. I adjusted the template to show the value as the default (Off) rather than On.

bschonec commented 9 years ago

I changed a good number of paramaters' default values to what php.net says are the default values.

I also added a few non-deprecated parameters that weren't available that I needed and I think should be available.

thias commented 9 years ago

I see where you're going, but my module's defaults are not upstream PHP defaults, they're based on the ones in the RHEL original file + maybe some best practices changes. For instance, there is no way I'm going to change the default of short_open_tag to On, or display_errors to On, that would be insane. And keep in mind that this would affect all existing users of my module.

No problem in adding new parameters, but please create separate smaller pull requests and :