search

thias / puppet-php

Puppet module to manage PHP
Other
49 stars 67 forks source link

Update php_conf_dir to be compatible with Debian 8 (Jessie) #69

Closed heskyji closed 9 years ago

heskyji commented 9 years ago

Debian Jessie removed the /etc/php5/conf.d directory and all symlinks inside to mods-available. Using mods-available directly seems better to me

kronos-pbrideau commented 9 years ago

To note, this patch is also compatible with debian 7 (wheezy) release.

It is even better to use mods-available on debian based distro instead of conf.d because of script in function dismod of script php5enmod, we see:

    for live_link in $(ls -1 /etc/php5/conf.d/*.ini); do
        # assert $modname is in /etc/php5/conf.d
    [ -h "${live_link}" ] || continue
        # assert $modname is a symlink to /etc/php5/mods-available

and using directly /etc/php5/conf.d for this module in debian create configs as files instead of symlinks

so to be able to enable/disable through php5dismod and php5enmod, this is better.

Any chance it get into master?

heskyji commented 9 years ago

Thanks @kronos-pbrideau .

I have rebased the feature branch on top of the current master. Any chance this get merged in master? :smile: