thias / puppet-php

Puppet module to manage PHP
Other
49 stars 67 forks source link

Allow changing of upload_tmp_path via parameter #8

Closed andyshinn closed 11 years ago

andyshinn commented 11 years ago

This is a fairly trivial addition to allow changing the upload_tmp_path via a parameter.

thias commented 11 years ago

This looks good. Could you please just put the upload_tmp_dir parameter in the same order as in the ini file, so in between file_uploads and upload_max_filesize? It makes it easier to compare the manifest to the template, which can be useful when looking for the defaults.

thias commented 11 years ago

I've made the change in 3b18c18c91e8dc0a1f8241bf1246c6e2221d1fca

andyshinn commented 11 years ago

Ah, didn't realize there was a sorting. Thanks!