thias / puppet-postfix

Puppet Postfix module
Other
17 stars 117 forks source link

Not able to disable postgrey #119

Open cfoehrdes opened 7 years ago

cfoehrdes commented 7 years ago

It seems to me that there is a bug in the current release as it suddenly always configures postgrey in the smtpd_recipient_restrictions. After having a look at the template for the main.cf there is only a condition which type of postgrey has to be configured and not a surounding condition if it should be configured at all:

<% if @postgrey_policy_service -%>
  check_policy_service <%= @postgrey_policy_service %>,
<% else -%>
  check_policy_service unix:postgrey/socket,
<% end -%>

should probably be:


<% if @postgrey -%>
<% if @postgrey_policy_service -%>
  check_policy_service <%= @postgrey_policy_service %>,
<% else -%>
  check_policy_service unix:postgrey/socket,
<% end -%>
<% end -%>
cfoehrdes commented 7 years ago

If just looked at older version and in version 0.3.3 it actually is surrounded by the condition.