search

thias / puppet-postfix

Puppet Postfix module
Other
17 stars 117 forks source link

Improper ordering of resources #18

Closed jbouse closed 10 years ago

jbouse commented 10 years ago

While trying to install on a new system from scratch I noticed that Postfix::File[header_checks] and Postfix::File[body_checks] attempt to be created before the postfix package is installed or the $postfixdir exists. For that matter there doesn't appear to be any check to ensure that the postfix directory exists and postfix::server does not expose as a parameter like postfix::file does but the call to postfix::file from within postfix::server doesn't pass the postfixdir so it uses the default.

jbouse commented 10 years ago

I don't have the time at the moment but if no one else can give attention to this before I do have time I'll get a PR together to fix this.

thias commented 10 years ago

This should be fixed in ae7d2466e0e6bfd05a5d2e277221e4fac323b709 (at last). It won't work with people still using mysql => true, but since that's only RHEL5, I think I'll rip it out of the module soon anyway.