add spec tests, lint cleanup

thias / puppet-postfix

Puppet Postfix module

Other

17 stars 117 forks source link

add spec tests, lint cleanup #2

Closed jlambert121 closed 10 years ago

jlambert121 commented 11 years ago

I need to enhance my postfix module and rather than do that and have another postfix module on the forge I would like to reuse/improve an existing one and help with the cleanup.

A few questions: Do you want to maintain EL5 compatibility? OK to break out the non-postfix stuff into their own modules? (I'll move them to you in GH) OK to add puppetlabs-stdlib as a dependency for the anchor pattern?

This commit: Added spec tests Added travis-ci integration (if you use travis - free for OSS) Minor lint cleanup

thias commented 10 years ago

Hi! Sorry for never getting back to you on this one :-(

I'm no longer interested in EL5 compatibility personally, but maybe some others using my module are... I have no way of knowing for sure.
What non-postfix stuff are you writing about to "break out"? I see only postfix service and file related resources in my module...
I'm not too keen on the stdlib dependency, nor do I like the anchor hack for ordering (even though I understand its use), but adding them properly wouldn't be a problem and I'd definitely accept it.

jlambert121 commented 10 years ago

Thanks for the response. I ended up writing my own postfix module so my questions aren't really relevant anymore. The extra stuff in this that kept me from using it is spamassassin, postgrey, and clamav. Feel free to merge this (or not) though if you'd like the tests on your existing module. It looks like I added stdlib to the fixtures, but didn't use it anywhere.

thias commented 10 years ago

Ah, ok, I see what you mean now. Those bits are indeed a bit legacy, but at least they're optional and disabled by default. If I had to re-create this module from scratch today, I would definitely do at lot differently...

Anyway, thanks for your feedback!