Open georgehansper opened 10 years ago
Thanks! Most of this looks good, but unfortunately it seems like including this would break all existing postgrey configurations which use the 'true' value use the socket.
Could you create separate PRs, one for the chroot change, one for the postgrey changes and one for the maildrop change? Two would be easy, and the postgrey one would be tricky. I also don't really like that it now installs a /etc/sysconfig/postgrey
file on RHEL, which simply doesn't work.
...onfig file
Most significantly, this change introduces the parameter
postfix_master_services_chroot
which modifies the column 'chroot (default yes)' in the master.cf file, to turn on chroot for those services that have it enabled by default in Debian.This change also adds the file: /etc/default/postgrey or /etc/sysconfig/postgrey And brings this under puppet control, so that it is consistent with the postfix setting. It also allows the user to specify
postgrey => 'inet:127.0.0.1:10023',
instead of simply true/false, so that the parameterpostgrey_policy_service
could be eliminated. The default setting was changed toinet:127.0.0.1:10023
because Debian systems do not come with the directory /var/spool/postfix/postgrey/Lastly, the parameter
maildrop_service
is introduced to allow the maildrop service to be uncommented in the master.cf file.