thias / puppet-postfix

Puppet Postfix module
Other
17 stars 117 forks source link

RH/CentOS release version comparison fix #35

Closed vholer closed 10 years ago

vholer commented 10 years ago

New CentOS 7 contains version information consisted of three components

# facter | grep -i 7.0.1406
lsbdistdescription => CentOS Linux release 7.0.1406 (Core) 
lsbdistrelease => 7.0.1406
operatingsystemrelease => 7.0.1406

and current simple check $::operatingsystemrelease < 6 fails on Puppet error "Error: comparison of String with 6 failed at". Function versioncmp is better for version comparisons.

adamcstephens commented 10 years ago

Similar goal to #34 but with a different implementation.

arenstar commented 10 years ago

Yes please!

thias commented 10 years ago

Thanks a lot!