thias / puppet-postfix

Puppet Postfix module
Other
17 stars 117 forks source link

$smtps_content_filter shouldn't be obligatory when using $ssl #57

Closed jhooyberghs closed 9 years ago

jhooyberghs commented 9 years ago

I found out that using ssl, forces users to also use smtps_content_filter. In my opinion this shouldn't be needed. I added a check in master.cf.erb for checking if smtps_content_filter is defined before looping over the array.

thias commented 9 years ago

It should default to an empty array, thus not put any lines, or an I re-reading my code wrong?

Maybe you have set $smtp_content_filter to something, in which case you would need to set smtps_content_filter => [] explicitly to avoid it having the same content?

thias commented 9 years ago

My bad. This is probably #32 and has been fixed in a1d5f76584721e0bbc5e13cc27c42ccb38308406 now.