Added support of master_disable_service.

thias / puppet-postfix

Puppet Postfix module

Other

17 stars 117 forks source link

Added support of master_disable_service. #76

Closed yarikdot closed 8 years ago

yarikdot commented 8 years ago

PR for #75

thias commented 8 years ago

This is interesting work, but waaaay too invasive. I can't reliably review all of this, so closing (sorry!). My two main concerns are :

The whole call to instance is very iterative, adding a new parameter would now require adding it in 3 different critical places (main class header, main class, definition header).
You've included waaaay too much, even your modified metadata.json and README.md which clearly shouldn't go back into my tree.

yarikdot commented 8 years ago

Hmm, strange. There should have been only that one change of master_service. I have forked the repo to implement the rest. Don't know why it tried to merge all my commits.