search

thias / puppet-postfix

Puppet Postfix module
Other
17 stars 117 forks source link

lint validation problem #79

Open khdevel opened 8 years ago

khdevel commented 8 years ago

Hello,

I would like to use your code in production but I see that my lint found some validation issues. There are some ERORS and WARNINGS: Please take a look on the list:

modules/postfix/manifests/server.pp - ERROR: single quoted string containing a variable found on line 50
modules/postfix/manifests/server.pp - ERROR: single quoted string containing a variable found on line 114
modules/postfix/manifests/server.pp - WARNING: ensure found on line but it's not the first attribute on line 181
modules/postfix/manifests/server.pp - WARNING: ensure found on line but it's not the first attribute on line 205
modules/postfix/manifests/server.pp - WARNING: ensure found on line but it's not the first attribute on line 228

Those WARNINGS are minor problem but I have problem with those two ERROR. They are related to some variables which are in the single-quote:

  $dovecot_destination = '${recipient}',

and

  $postscreen_greet_wait       = '${stress?2}${stress:6}s',

Will it be a problem for you to fix it (write in some other way)?

Thank you!