search

thias / puppet-sysctl

Puppet module to manage sysctl parameters
Other
35 stars 82 forks source link

fix for purge option; disabling purge by defaut #7

Closed tehmaspc closed 10 years ago

tehmaspc commented 10 years ago

Hi,

The purge option to wipe out anything under /etc/sysctl.d which is not managed by sysctl - this option only works when 'recurse = true' is set. Thus, this patch adds the recurse option setting depending on what purge is set to.

This patch changes the default of purge to be 'false' since I feel it's safer to have false as the default and also since adding recurse will now make the purge work - we want to ensure that users of this module don't accidentally begin to see sysctl configuration settings wiped from their system if they were to upgrade their respective copies of this 'puppet-sysctl' module.

Tehmasp Chaudhri @tehmaspc

thias commented 10 years ago

Looks good, thanks a lot. And since the purge was actually not working until now, I have no objection to making false the default.