Add file/folder description (and other new features and bugfixes)

Anarky commented 9 years ago

Hello,

This is a pretty big PR; I made a summary of it, but every fix or new feature has its own commit. Please tell me if you want me to split it in smaller PRs.

New features:

title for buttons
new spinner when loading a photoshere
more translatable elements, all translated in French
rename/move metadatas when moving/renaming its associated file
add a description to a file or folder (some changes had to be made on the CSS)

Fixes:

proper basename fix
RSS (hide RSS button and complete deactivation)
thumbnails size option not saved
disable javascript inside inputs and textareas
file renaming (when renaming to the same name or if the new name already exists)
rec_del() behaviour
don't show comments if we don't have the right to view its associated file

And some dead code removal.

Anarky commented 8 years ago

Hello Thibaud, I really would like your opinion on this pull request; tell me if you want me to rework some changes or split them.

thibaud-rohmer commented 8 years ago

Hey Anarky,

I haven't forgotten about your pull request, it's just that it's so big it takes me quite some time to review :)

I have no change requests so far, and I hope to be able to merge it soon !

Thanks !

On Fri, 31 Jul 2015 at 00:09 Anarky notifications@github.com wrote:

Hello Thibaud, I really would like your opinion on this pull request; tell me if you want me to rework some changes or split them.

— Reply to this email directly or view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/pull/289#issuecomment-126506700 .

Anarky commented 8 years ago

Hello Thibaud,

If you are still planning to merge my changes, please tell me and I will resolve the conflicts.

Regards,

thibaud-rohmer / PhotoShow

Add file/folder description (and other new features and bugfixes) #289