search

thibaud-rohmer / PhotoShow

A free web gallery in PHP with drag-n-drop support
http://www.photoshow-gallery.com
505 stars 152 forks source link

Allows to download filenames with ' and " #292

Closed cyosp closed 9 years ago

cyosp commented 9 years ago

It's now possible to download a ZIP archive which contains filenames (directories) which have characters ' and ". Thus for example, it will allow to download a ZIP file of: http://www.photoshow-gallery.com/demo/?f=France%2FIle+d%27Arz. Tested with a Debian Jessie GNU/Linux server.

thibaud-rohmer commented 9 years ago

Awesome !

cyosp commented 9 years ago

Hi Thibaud,

I'm new on Github and it's my first open source project contribution. This morning I've sent to you my pull request: Allows to download filenames with ' and ". But after I've merged my branch "dot-in-login" to my master one. Unfortunately now you have in your master one:

The second one was a pull request I would like to submit to you but in a dedicated pull request. It allows to have character '.' in login name. This need because I've migrated my photo gallery from plogger to photoshow and my previous logins were with character '.' and I need to keep same logins as before. Up to you to keep this change or not. File impacted is "Account.php".

Sorry for the inconvenience.

Best regards, cyops

thibaud-rohmer commented 9 years ago

Hi, cyops !

No worries there, I always look at the code when merging pull requests (and at the list of commits included). I did see that difference, but I liked it.

So, absolutely no inconvenience. Thank you very much for your contribution, and hey, now that you're on Github, it's time to start your own projects too ! ;)

On Tue, 28 Jul 2015 at 22:22 cyosp notifications@github.com wrote:

Hi Thibaud,

I'm new on Github and it's my first open source project contribution. This morning I've sent to you my pull request: Allows to download filenames with ' and ". But after I've merged my branch "dot-in-login" to my master one. Unfortunately now you have in your master one:

  • Allows to download filenames with ' and "
  • Allows character '.' in login

The second one was a pull request I would like to submit to you but in a dedicated pull request. It allows to have character '.' in login name. This need because I've migrated my photo gallery from plogger http://www.plogger.org to photoshow http://www.photoshow-gallery.com/ and my previous logins were with character '.' and I need to keep same logins as before. Up to you to keep this change or not. File impacted is "Account.php".

Sorry for the inconvenience.

Best regards, cyops

— Reply to this email directly or view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/pull/292#issuecomment-125743598 .