Prevent to have anamorphic thumbnails

[cyosp]

This little CSS change avoids to have thumbnail images anamorphic regardless of the screen width like it's already the case for http://www.photoshow-gallery.com/demo/

[cyosp]

Hello Thibaud,

This Pull Request is only 5 characters change. Can you find a little time to include it ?

Thank you, CYOSP

[thibaud-rohmer]

Hi CYOSP,

Doesn't matter the size of it : this changes a CSS property, so I want to check it on several browsers for compatibility :)

I'll include it as soon as I've done that.

Thank you !

Thibaud

On Tue, 15 Dec 2015 at 07:07 cyosp notifications@github.com wrote:

Hello Thibaud,

This Pull Request is only 5 characters change. Can you find a little time to include it ?

Thank you, CYOSP

— Reply to this email directly or view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/pull/304#issuecomment-164652741 .

[cyosp]

Hi Thibaud,

Do you have had some time to test this modification on browsers ?

Best regards, CYOSP

[thibaud-rohmer]

Not yet I'll try to get on it this week :)

Le lun. 8 févr. 2016 08:18, cyosp notifications@github.com a écrit :

Hi Thibaud,

Do you have had some time to test this modification on browsers ?

Best regards, CYOSP

— Reply to this email directly or view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/pull/304#issuecomment-181234230 .

[cyosp]

Some news ;)

[andiges]

Hi, i checked this site here http://www.w3schools.com/cssref/pr_dim_max-height.asp max-height has no "auto" value, Firefox 46.0.1 ignores this property.

[cyosp]

Hi Andrej,

You are right, thank you. My Iceweasel 38.8.0 under Debian/Jessie do the same. At the end it produces the expected result. In fact there is also no property max-height set in the demo site: http://www.photoshow-gallery.com/demo/.

I will back with a commit in this way.

Have a nice day, CYOSP

[thibaud-rohmer]

cyosp, I think the property you want to edit (max-height) still needs to be set at an actual value, and here's why : if PhotoShow cannot generate a thumbnail, it defaults to displaying the base image. That base image can have any possible size, and so, it is important to specify its max-height, else we will end up with various image heights in the thumbnails display.

When you test your code, can you check that it also works without thumbnail generation ? (to do so, you can, for instance, lock the rights in the thumbnails folder to prevent your webserver from writing in it).

I'd like also to apologize for the huge time I take responding to all information posted here. I really hope I'll be able to have more time to dev on PhotoShow in the future, but please know that at the moment, it is sadly not my priority. I still read all of it, be sure of it.

Thanks for using photoshow and for improving it :D ! It is greatly appreciated !

On Tue, 24 May 2016 at 07:47 cyosp notifications@github.com wrote:

Hi Andrej,

You are right, thank you. My Iceweasel 38.8.0 under Debian/Jessie do the same. At the end it produces the expected result. In fact there is also no property max-height set in the demo site: http://www.photoshow-gallery.com/demo/.

I will back with a commit in this way.

Have a nice day, CYOSP

— You are receiving this because you commented.

Reply to this email directly or view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/pull/304#issuecomment-221172434

[cyosp]

Thibaud,

There is no problem and I appreciate you take of your time to give me an answer even if Photoshow is not your priority for the moment. I'm working to a solution in order to have it working without max-height set and regardless of input image size.

I will let you know and you or another people will give me a feedback when possible

[cyosp]

I close this pull request and will open a new one later