search

thibaud-rohmer / PhotoShow

A free web gallery in PHP with drag-n-drop support
http://www.photoshow-gallery.com
502 stars 151 forks source link

is it possible to set the album image? #317

Open spassvogel opened 7 years ago

spassvogel commented 7 years ago

or is this always random?

thibaud-rohmer commented 7 years ago

It' s the first image (alphabetical order) it finds in the album that is displayed.

On Mon, 31 Oct 2016 at 19:41 spassvogel notifications@github.com wrote:

or is this always random?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/issues/317, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgnQ6ZoXlv4IKOzR8BQaNs7uNW_BAA2ks5q5jZxgaJpZM4KlXAE .

spassvogel commented 7 years ago

Hi Thibaud!

Thank you so much for your response. It clarifies a lot, so as a workaround I guess I can prefix an image with an underscore or something to make it the album title.

However.. I think it would be very nice if one could manually select an image to be the album cover. I have to confess my PHP is kind of rusty, but if I do get it working are you willing to accept a merge request that does this? (if it lives up to your standards, of course)

thibaud-rohmer commented 7 years ago

Hey !

Well, thank you for using photoshow in the first place ;)

A lot of people request this change. If you manage to do it, I'll try to find the time to review it (as you may have noticed on github, I usually have very little time, especially for pull requests). I promise I'll do my best to try to review it. For others that have pull requests pending : I'll try this weekend, I should have some time at some point... ^^

On Wed, 2 Nov 2016 at 14:59 spassvogel notifications@github.com wrote:

Hi Thibaud!

Thank you so much for your response. It clarifies a lot, so as a workaround I guess I can prefix an image with an underscore or something to make it the album title.

However.. I think it would be very nice if one could manually select an image to be the album cover. I have to confess my PHP is kind of rusty, but if I do get it working are you willing to accept a merge request that does this? (if it lives up to your standards, of course)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/issues/317#issuecomment-257872112, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgnQ3OcdoQzpjo58oLp_elJ8onGyy4sks5q6JdFgaJpZM4KlXAE .

spassvogel commented 7 years ago

Actually, looking through the pull requests I see that some of them implement some sort of metadata of directories (by using an XML). This one looks promising: https://github.com/thibaud-rohmer/PhotoShow/pull/289. That's quite useful also for setting the album image.

So I'm going to wait and hope it gets merged and work from there. :)