search

thibaud-rohmer / PhotoShow

A free web gallery in PHP with drag-n-drop support
http://www.photoshow-gallery.com
505 stars 152 forks source link

Selectable album thumbnail #347

Closed alesc closed 7 years ago

alesc commented 7 years ago
gboudreau commented 7 years ago

@alesc Why did you close your own PR? Is there a problem with it, or ..?

alesc commented 7 years ago

I forgot to variabilize some elements in Judge.php, I've closed this PR to make necessary changes and I will submit it again. It is the first time I'm really using github, I don't know if I can let a PR open and make changes ...

thibaud-rohmer commented 7 years ago

Very good practice, thanks that !

You can leave the PR open (and every new commit you add to your branch is directly added in the PR). But it would mean that I (the reviewer) might accept and merge it before you've made the edits. So I prefer if you do it like that :)

On Thu, 28 Sep 2017 at 15:00 alesc notifications@github.com wrote:

I forgot to variabilize some elements in Judge.php, I've closed this PR to make necessary changes and I will submit it again. It is the first time I'm really using github, I don't know if I can let a PR open and make changes ...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/pull/347#issuecomment-332828701, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgnQzn0DTakrFXOss9JLDsoz9qC9hIIks5sm5hdgaJpZM4PkgSw .

alesc commented 7 years ago

Due to force-push I did, githut won't reopen this PR. So I will make a new one. Sorry for spam.

thibaud-rohmer commented 7 years ago

No problem :)

On Thu, 28 Sep 2017 at 15:26 alesc notifications@github.com wrote:

Due to force-push I did, githut won't reopen this PR. So I will make a new one. Sorry for spam.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/thibaud-rohmer/PhotoShow/pull/347#issuecomment-332835497, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgnQy1L3EGyQNMMstSxyDOJTrDxfp19ks5sm550gaJpZM4PkgSw .