search

thibaudgg / video_info

Get video info from Dailymotion, Vimeo, Wistia, and YouTube URLs.
https://rubygems.org/gems/video_info
MIT License
428 stars 132 forks source link

YouTube provider does not fetch standard #191

Closed ishields closed 4 years ago

ishields commented 4 years ago

The thumbnail_large method for the YouTube provider returns an image who's size is only 480x360 ex: https://i.ytimg.com/vi/cDmyGzFHMsE/hqdefault.jpg

The YouTube api returns an additional size of image that isn't accssible.
ex standard: https://i.ytimg.com/vi/cDmyGzFHMsE/sddefault.jpg

I think we need to add an additional thumbnail size.

thumbnail_large_2x

For other providers I will simply return the large thumbnail.

ishields commented 4 years ago

I was mistaken. There is only one missing size - standard. Updated ticket.

thibaudgg commented 4 years ago

Sure, I think that would be good to add, PR always appreciated 👍

ishields commented 4 years ago

Is the plan to make a release for these two most recent fixes?

thibaudgg commented 4 years ago

I have just released version 2.8, thanks for your help.