search

thibaudgg / video_info

Get video info from Dailymotion, Vimeo, Wistia, and YouTube URLs.
https://rubygems.org/gems/video_info
MIT License
428 stars 132 forks source link

🛠️ Fix specs and update deps #211

Closed markets closed 1 year ago

markets commented 1 year ago

EXTRAS

markets commented 1 year ago

@thibaudgg I started some work! Dailymotion, Wistia and Vimeo scraper are fully passing now ✔️

To continue with Vimeo and Youtube I need I think those API keys. Do we have some keys for testing 🙏🏼? I'd like to avoid creating accounts and setup apps in each service 😅. The CI (or any other contributor) will need them anyway, so probably we need to think a more comfortable solution for that. How did you do it in the past?

thibaudgg commented 1 year ago

@thibaudgg I started some work! Dailymotion and Wistia are fully passing now.

Awesome! 🙌🏻

To continue with Vimeo and Youtube I need I think those API keys. Do we have some keys for testing 🙏🏼? I'd like to avoid creating accounts and setup apps in each service 😅. The CI (or any other contributor) will need them anyway, so probably we need to think a more comfortable solution for that. How did you do it in the past?

Good question, I wasn't able to find back the YOUTUBE_API_KEY and VIMEO_ACCESS_TOKEN that I was using in the past 🙈. It would be great if you could create new test accounts for those two, ensure these credentials aren't present in the VCR (you can filter sensitive data) cassettes and then send me privately your keys so I can set them on the repo secret actions variables. What do you think about this setup?

markets commented 1 year ago

What do you think about this setup?

Not really like it, because any contributor will need those keys to be able to run the tests... but I don't have any other proposal right now :)

Since those keys are just for testing purposes, probably we can just share them with very low risk.

To be honest, I'm very lazy about creating those keys 😅... I'd like to finish this task and send some other small improvements to the project, but if someone can provide me a couple of keys that would help me a lot 👌🏼 maybe @joaocv3 (last maintainer that touched those files) have some valid keys 🙏🏼?

joaocv3 commented 1 year ago

Hey @markets! I actually still have them 🙏

I'll email them to you and Thibaud.

I like the ideia of having project keys for future maintainers though. I will create a Google account and keys for the project as soon as I have some time.

markets commented 1 year ago

Only 1 spec failing (related to Vimeo API)!

Failures:

  1) VideoInfo::Providers::Vimeo with video 136971428 #view_count is expected to be > 80
     Failure/Error: it { is_expected.to be > 80 }

       expected: > 80
            got:   0
     # ./spec/lib/video_info/providers/vimeo_spec.rb:210:in `block (5 levels) in <top (required)>'

Finished in 17.98 seconds (files took 1.15 seconds to load)
409 examples, 1 failure, 2 pending

It seems the API doesn't return this data (you can try it here: https://developer.vimeo.com/api/reference/videos#get_video with this video id 136971428) anymore ... 

"stats": { "plays": null }

From what I'm reading on some issues, I think we should change some configuration in the used API key: