search

thibaultcha / lua-cassandra

Pure Lua driver for Apache Cassandra
https://thibaultcha.github.io/lua-cassandra
Other
98 stars 35 forks source link

Fix 01-rockspec tests #107

Closed drolando closed 6 years ago

drolando commented 6 years ago

These tests assume the 'find *.rockspec' command will return the 2 rockspec files in a specific order (first the prod one and then dev).

This is not always true. It might depend on the OS, find implementation or something else, I don't know. But we can't assume any order.

So I've changed the code so that it'll now try to match the filenames.

drolando commented 6 years ago

working example at https://repl.it/MKtc

Also, ignore the failing build. It's broken on master too. Looks like travis if failing to download ccm for some reason. I'll fix that in another PR

thibaultcha commented 6 years ago

That looks good @drolando, thanks!

However, if the CI is not working (even though I understand it isn't your fault), I cannot merge this. I will try to fix the CI environment as soon as I can!

thibaultcha commented 6 years ago

Thank you!