thibaultcha / lua-cassandra

Pure Lua driver for Apache Cassandra
https://thibaultcha.github.io/lua-cassandra
Other
98 stars 35 forks source link

Getting Scylla Working - missing the code to build scylla #120

Open slivne opened 5 years ago

slivne commented 5 years ago

https://github.com/thibaultcha/lua-cassandra/blob/232e9688e4810d23c9a6420e7be7d7e9c7feadb8/.ci/setup_env.sh#L26 in the setup you are building scylla-jmx and scylla-tools-java, you are missing the code to build scylla.

you can follow https://github.com/scylladb/scylla#quick-start

(one niptick ... by default you will build unitests as well ... which will take longer) ./configure.py --mode=release --with=scylla

In addition to that https://github.com/thibaultcha/lua-cassandra/blob/232e9688e4810d23c9a6420e7be7d7e9c7feadb8/.ci/setup_env.sh#L39

SCYLLADB_DIR needs to point to the scylla directory - not the scylla-tools-java

thibaultcha commented 5 years ago

Thank you for the tips @slivne.

You may want to consider improving the documentation around scylla-ccm a bit. Unless I drastically missed it, nothing here hints that scylla-ccm won't build Scylla itself. In fact, it just says:

Download scylla-ccm: ...

The SCYLLADB_DIR env originally was the scylla directory, but I changed it just to give it a try after seeing both the scylla dir and the scylla-tools-dir suggested while sourcing scylla_ccm_env.sh. I suppose the latter is only for a Cassandra cluster after all.

I will give another try soon, thanks again!

slivne commented 5 years ago

@thibaultcha thanks - you are correct it was missing. I modified the instructions to include building scylla.