search

thibaultcha / lua-cassandra

Pure Lua driver for Apache Cassandra
https://thibaultcha.github.io/lua-cassandra
Other
98 stars 35 forks source link

Added missing locals, added nan to cql #83

Closed bungle closed 7 years ago

bungle commented 7 years ago

@thibaultcha, I'm not sure if you are interested to merge this as this mostly contains cosmetic changes. I wanted to check that my development environment works with this module, e.g. runs all the tests, coverage reports, linting etc., and meanwhile I did some small changes. This PR doesn't break anything, but it is up to you if you consider this to be merged.

bungle commented 7 years ago

It is possible that the nan addition generates a slightly worse Lua bytecode, but I may be more clear, or just to be consistent use similar numbers in both (0/0, not 0/0 and 0.0/0.0)?

thibaultcha commented 7 years ago

Hi!

Thanks for this. I suggest taking a quick look to the next version of this module in refactor/style+perf (which already has a new cql2.lua module). It focuses hugely on performance and style, as per the name. I haven't looked entirely at this PR so all changes might not be relevant anymore, but I would love for some of those changes to get ported there if necessary!

bungle commented 7 years ago

Ok. I can take a look at that. I will close this.