Fix aggregation if the same class name exists in two different namespaces

thibaultmarin / hpp2plantuml

Convert C++ header files to PlantUML

MIT License

223 stars 35 forks source link

Fix aggregation if the same class name exists in two different namespaces #32

Open bansan85 opened 3 months ago

bansan85 commented 3 months ago

Aggregation is randomly wrong if the same class name exists in two different namespaces.

thibaultmarin commented 3 months ago

Thanks for the pull request. This reveals a more widespread bug that affects all class relationships. v0.8.5 attempts to fix it, could you please give it a try and post an example if you still observe issues? Thanks

bansan85 commented 3 months ago

Thanks for the fix. I will test it in few days.

By the way, I also sent fixes in robotpy/CppHeaderParser. I will be great if you could update to the latest commit.

bansan85 commented 3 months ago

It's really better but I still have one problem.

If I run "hpp2plantuml.py -i urx/*.h -o architecture.puml"

urx.zip

I randomly have:

/' Aggregation relationships '/

urx.detail.Acquisition "2" *-- urx.detail.Group

urx.detail.GroupData *-- urx.detail.Group

/' Aggregation relationships '/

urx.detail.Acquisition *-- urx.detail.Group

urx.detail.Acquisition *-- urx.detail.GroupData

urx.detail.GroupData *-- urx.detail.Group