search

thibaultyou / tradingview-alerts-processor

Minimalist service designed to execute TradingView webhooks and process them to cryptocurrencies exchanges.
MIT License
79 stars 23 forks source link

Add some database service tests and update dependencies #29

Closed leifjones closed 2 years ago

leifjones commented 2 years ago

  1. Update dependencies. (Discussion is open setting versions precisely vs allowing for patch/minor updates.)

  2. Add a DatabaseService test and draft some potential other tests, noting options and barriers. (See interim approach.)

  3. Add madge dev dependency, which informs us of circular dependencies via this bash command: ./node_modules/madge/bin/cli.js --circular --extensions ts ./

  4. Add tests for JSON db service and some for Redis db services, including minor refactor to allow for injection.

leifjones commented 2 years ago

Hoping it makes sense to do small PRs like this with the few tests I do as I can. At least early on, I'm prioritizing getting a chance to sync up on patterns and such.

thibaultyou commented 2 years ago

Of course it makes sense to do PR like this !

My personal preference is to fix versions for dependencies to ensure that everyone is running the same code and frequently update them in separated commits with npm-check-updates.